elastic / elastic/logstash

Clarify stalling_thread_info in log messages

Open
#6,908 1 comment 2 reactions 0 assignees View on GitHub
enhancement logging improvements
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

As part of the shutdown watcher, we write a field named `stalling_thread_info` out to the log files:

```
stalling_thread_info"=>{"other"=>[{"thread_id"=>38, "name"=>"[main]"[...]/vendor/bundle/jruby/1.9/gems/logstash-input-beats-3.1.12-java/lib/logstash/inputs/beats.rb:213:in `run'"}, {"thread_id"=>39, "name"=>"[main]"[...]/vendor/bundle/jruby/1.9/gems/logstash-input-beats-3.1.12-java/lib/logstash/inputs/beats.rb:213:in `run'"}, {"thread_id"=>40, "name"=>"[main]"[...]/vendor/bundle/jruby/1.9/gems/logstash-input-beats-3.1.12-java/lib/logstash/inputs/beats.rb:213:in `run'"}], ["LogStash::Filters::Mutate",
```
Perhaps we can revisit and look into renaming `stalling_thread_info` to something that indicates outstanding threads for just seeing threads listed here doesn't necessarily mean that something is getting stuck/stalled or is hanging. The shutdown process can actually be working and eventually shut down the JVM gracefully. "Stalling" can be misinterpreted as something that has gone wrong.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.