elastic / elastic/logstash

Small mistake in grammar.treetop (Logstash config parser)

Open
#6,580 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

There is a rule for `array_value` in the treetop parser definition (https://github.com/elastic/logstash/blob/master/logstash-core/lib/logstash/config/grammar.treetop#L66-L68), which is never used. So I assume that either this definition could be removed or maybe more likely this rule should be used for values in arrays on https://github.com/elastic/logstash/blob/master/logstash-core/lib/logstash/config/grammar.treetop#L100 as I guess, that a `plugin` is not a valid value within an array (this is the difference between the rules for `value` and `array_value`).

@jordansissel I guess you should have a look at this.

If you wish, I could provide a PR.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.