elastic / elastic/logstash

Have package installers install logstash.yml.dist

Open
#6,076 0 comments 0 reactions 0 assignees View on GitHub
Pioneer Program
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

Ref #6073 from @dcode

When upgrading RPM/DEB packages, the installed file may not be overwritten. In such cases, we should change the pre-install script (or after-install script, wherever it's easier) as follows:
1. If there is no logstash.yml, install the package version and a copy as logstash.yml.dist
2. If there is an existing logstash.yml, and there is no logstash.yml.dist, do not overwrite logstash.yml, but install logstash.yml.dist
3. If both logstash.yml and logstash.yml.dist exist, overwrite logstash.yml.dist with the package version, and leave the existing logstash.yml alone.

I believe we can squeeze this in for 5.0 release since it is package-level and does not affect existing Logstash code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.