elastic / elastic/logstash

sysv init script - minor syntax 'bug' when setting default value for shell variable

Open
#5,527 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

As discussed in the notes to 08fa8798269e5df9e74227a1d78e35c21e11031c it should be

`KILL_ON_STOP_TIMEOUT=${KILL_ON_STOP_TIMEOUT:-0}`

(i.e. with the colon).

Issue as per request by @purbon

Contributor guide

Open the contributing guide

Research direction

Locate the SysV init script and inspect the assignment for KILL_ON_STOP_TIMEOUT, using commit 08fa8798269e5df9e74227a1d78e35c21e11031c as context. Confirm the shell default-value syntax and run the relevant init-script checks, if present; done means the assignment includes the colon and remains valid shell syntax.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.