elastic / elastic/logstash

rename bootstrap environment module to differentiate from logstash-core environment

Open
#5,373 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

Per #5361 discussion, we should rename the bootstrap `Environment` module https://github.com/elastic/logstash/blob/ec95659dbda5792295b0d330024413fec5983901/lib/bootstrap/environment.rb to differentiate from the logstash-core `Environment` module https://github.com/elastic/logstash/blob/ec95659dbda5792295b0d330024413fec5983901/logstash-core/lib/logstash/environment.rb

The idea is what is defined in the bootstrap environment is only relevant and usable when in the context of launching the logstash app and should not be used in logstash-core code that could run outside the context of launching logstash, for example when running a plugin specs which includes the logstash-core gem.

I will also followup with another issue to remove launching specific code like `Runner` outside logstash-core.

Contributor guide

Open the contributing guide

Research direction

Start with lib/bootstrap/environment.rb and logstash-core/lib/logstash/environment.rb, then trace references to both Environment modules, especially from bootstrap startup and plugin specs using the logstash-core gem. Done means the bootstrap module has a distinct name and logstash-core code does not depend on launching-specific environment behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.