elastic / elastic/logstash

Java Event is missing an implementation of `validate_value`

Open
#5,349 3 comments 0 reactions 0 assignees View on GitHub
code cleanup discuss v5.5.0
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

https://github.com/elastic/logstash/blob/master/logstash-core-event-java/src/main/java/com/logstash/ext/JrubyEventExtLibrary.java#L308

``` java
@JRubyMethod(name = "validate_value", required = 1, meta = true)
public static IRubyObject ruby_validate_value(ThreadContext context, IRubyObject recv, IRubyObject value)
{
// TODO: add UTF-8 validation
return value;
}
```

Is this even still necessary? @colinsurprenant

Contributor guide

Open the contributing guide

Research direction

Start with logstash-core-event-java/src/main/java/com/logstash/ext/JrubyEventExtLibrary.java at the validate_value method around line 308, then inspect its callers and related event validation behavior. Determine whether UTF-8 validation is still required; done means resolving that question and, if required, adding the validation with coverage for the affected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, ruby
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.