elastic / elastic/logstash

Not flushing batching codecs on shut down.

Open
#5,300 0 comments 0 reactions 1 assignee Claimed by @jsvd View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

On shut down, there is no way to signal a batching codec that it should flush it's contents. This results in message loss.

As a work around, have made the following local patch to the RabbitMQ output plugin
def close
+ # Close the codec if it supports this, to flush any outstanding entries
+ # needed for buffering codecs.
+ codec.do_close if codec.respond_to?( :do_close)
close_connection
end

Is there a better way to do this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.