elastic / elastic/logstash

LogStash should call shutdown hooks

Open
#5,174 2 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

Currently, LogStash will shutdown by waiting for events to flush out and then call `do_close` on plugins. If `--allow-unsafe-shutdown` is specified then LogStash shutdown watcher will call `Kernel.exit` after some time.

However, ZeroMQ plugins will block under certain condition (this is by design of ZeroMQ), thus events will never flush out and `do_close` will never be called. The way to unblock the sockets is by terminating the ZeroMQ context. This can be done allowing a shutdown hook to be called before exiting forcefully.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.