elastic / elastic/logstash

Make "tag_on_failure" a common filter setting

Open
#5,073 1 comment 4 reactions 0 assignees View on GitHub
enhancement v5.5.0
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

The `tag_on_failure` setting for the grok filter is very helpful with longer pipelines containing multiple grok filters, making it easier to locate the error in the pipeline, and more robust error handling.

For example, if a pipeline contained multiple [json filters](https://www.elastic.co/guide/en/logstash/current/plugins-filters-json.html), the ambiguous `_jsonparsefailure` is informative, but not entirely helpful.

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by locating the grok and json filter implementations and comparing how filter settings and failure tags are handled; clarify the intended common setting and identify the relevant test entry points before defining completion.

Written by the indexing model from the issue text.

Assessment

Domain
data-engineering
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.