elastic / elastic/logstash

reset or avoid global counter when compiling a pipeline

Open
#4,975 0 comments 0 reactions 0 assignees View on GitHub
code cleanup
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

currently in https://github.com/elastic/logstash/blob/master/logstash-core/lib/logstash/config/config_ast.rb#L140 a global counter is defined and used to avoid clashing method names
this counter isn't reset for each compilation and there's not reason not to.
not reseting it makes the generated code harder to understand

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.