elastic / elastic/logstash

Add guards for the `MetricStore`

Open
#4,506 3 comments 0 reactions 0 assignees View on GitHub
monitoring
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

The Metric store would benefit from some guards to protect the data.
- The current implementation of the `MetricStore` can grow unbounded, we should add guards on the size of it to make sure its stays under control and log that information.
- We can create namspace in unknown location we might want to secure or protect them, this is from a discussion from this PR https://github.com/elastic/logstash/pull/4602#discussion_r51735098

Contributor guide

Open the contributing guide

Research direction

Start by locating the MetricStore implementation and reviewing how it stores metrics and creates namespaces. Read the linked pull request discussion for the namespace concern, then identify existing logging and test conventions. Done means bounded storage, protected namespace creation, and logging for guard-triggered conditions, with tests covering the new behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.