elastic / elastic/logstash

Fix for #4303 breaks with $JAVA_OPTS set

Open
#4,331 2 comments 0 reactions 1 assignee Claimed by @purbon View on GitHub
bug packaging
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

The fix for #4303 breaks when `$JAVA_OPTS` is set.

[When it's set](https://github.com/elastic/logstash/blob/master/bin/logstash.lib.sh#L51), then [HEAP_DUMP_PATH](https://github.com/elastic/logstash/blob/master/bin/logstash.lib.sh#L66) will be empty. Which then leads to [passing just -J](https://github.com/elastic/logstash/blob/master/bin/logstash.lib.sh#L179) to jruby, which is not recognized as a valid option.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.