elastic / elastic/logstash

[plugins] gemspec files includes all vendor/ files

Open
#4,242 5 comments 0 reactions 0 assignees View on GitHub
bug packaging
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

most plugins have this gemspec **files** specification

```
s.files = Dir['lib/**/*','spec/**/*','vendor/**/*','*.gemspec','*.md','CONTRIBUTORS','Gemfile','LICENSE','NOTICE.TXT']
```

the `vendor/**/*` pattern will include all bundled gems if/when building the gem locally when using the "standard" `vendor/` bundle path config.

for some plugins, some files in `vendor/` need to be included, like the geoip database in the geoip filter or jar files for other plugins.

we could either use other directories for non-bundle gems vendored files like `vendor/data` and `vendor/jar` ? or we could exclude the gems specific directories in `vendor/` :

```
drwxr-xr-x+ 18 colin staff 612 Nov 12 2014 bin
drwxr-xr-x+ 63 colin staff 2.1K Nov 12 2014 build_info
drwxr-xr-x+ 63 colin staff 2.1K Nov 12 2014 cache
drwxr-xr-x+ 2 colin staff 68 Nov 12 2014 doc
drwxr-xr-x+ 63 colin staff 2.1K Nov 12 2014 gems
drwxr-xr-x+ 63 colin staff 2.1K Nov 12 2014 specifications
```

@ph is this files specification normally standard across all plugins and updated with the plugins mass update scripts?

thoughts?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.