DRY bootstrap/environment.rb & logstash-core/lib/logstash/environment.rb
Open
code cleanup
v6.0.0
- Dominant language
- Java
- Stars
- 14.9k
- Forks
- 3.5k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 88
Description
the `jruby?` and `windows?` methods have been duplicated by #3404 and we should remove them from `logstash-core/lib/logstash/environment.rb` and make sure they are properly loaded at startup from `bootstrap/environment.rb`. #4123 removed the automatic re-injection of `bootstrap/environment.rb` into `logstash-core/lib/logstash/environment.rb` so this need to be verified.
Contributor guide
Research direction
Compare bootstrap/environment.rb with logstash-core/lib/logstash/environment.rb, focusing on the duplicated jruby? and windows? methods and the startup loading path. Verify that removing the duplicates still loads both methods from bootstrap/environment.rb at startup, accounting for the change in #4123.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100