elastic / elastic/logstash

[meta] DRY udp/tcp/graphite input plugins specs & spec helpers

Open
#4,006 1 comment 0 reactions 0 assignees View on GitHub
code cleanup
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

The udp, tcp and graphite input plugins are defining pretty much the same spec helper. It should be DRY'ed up.

Also, @purbon suggested some spec refactors in logstash-plugins/logstash-input-graphite/pull/3 which we should followup on.

Contributor guide

Open the contributing guide

Research direction

Compare the spec helpers in the udp, tcp, and graphite input plugin specs, then review the suggested refactors in logstash-plugins/logstash-input-graphite/pull/3. Consolidate the duplicated helper setup and apply the agreed spec refactors; done means the three plugin specs remain equivalent and their tests pass.

Written by the indexing model from the issue text.

Assessment

Domain
testing, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.