elastic / elastic/logstash

Ensure vendored lockfile stays in sync with changes to gemspec/Gemfile/plugins/versions

Open
#19,262 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

There have been several changes recently which resulted in drift between the checked in lockfile and the actual spec defined by our gemspec, Gemfile.template, versions.yml etc.
- https://github.com/elastic/logstash/pull/19234
- https://github.com/elastic/logstash/pull/19233

During packaging and testing the lockfile is silently "repaired" such that the input spec are respected. We should come up with a strategy for detecting this drift and ensuring we take action. This could be a PR ci step in which we do a build and compare the generated lockfile with the one currently checked in and assert it matches. This would help us ensure that the vendored lockfile is accurately defining the gems that ship with logstash artifacts.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the checked-in vendored lockfile alongside the gemspec, Gemfile.template, and versions.yml, then inspect how packaging and testing currently generate or repair the lockfile. Define a CI build-and-compare check; done means CI detects and rejects drift between the generated lockfile and the checked-in file.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.