elastic / elastic/logstash

Likely unreachable code can likely be removed

Open
#19,014 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

The code in `LogStash::Runner` that [validates the java version](https://github.com/elastic/logstash/blob/894ca214c91bf9eabeb80a8f5c8956ee0dfc6b5c/logstash-core/lib/logstash/runner.rb#L292-L295) is likely unreachable due to similar logic in the `JvmOptionsParser` that is always hit first in the bootstrapping of the process.

Determine if it (and the relevant i18n entries) can be safely removed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.