elastic / elastic/logstash

Evaluate using google cloud BOM in Logstash

Open
#19,002 0 comments 1 reaction 1 assignee Claimed by @mashhurs View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

### Description
In Logstash google (input and output) pubsub plugins, we received bug reports that users faced `NoClassDefFoundError` after our plugins re-packaging change. The root cause was `google-pubsub` vs gRPC vs `protobuf` dependencies versions mismatch. Recently, I found that [google cloud BOM](https://docs.cloud.google.com/java/docs/bom) is a source of truth for the libraries version alignment, which google has a validation CI - https://github.com/googleapis/java-cloud-bom/issues/735

So far, we have a fix for the
- `input-google_pubsub`: https://github.com/logstash-plugins/logstash-input-google_pubsub/pull/78
- `output-google_pubsub`: https://github.com/logstash-plugins/logstash-output-google_pubsub/pull/36

and it looks like we can extend this to other plugins and possible to the core as well.
The plugin candidates as I can remember are:
- `input-google_cloud_storage`
- `output-google_bigquery`

In the core, we have guava, netty protobuf (it it is also related) and `googlejavaformat` libraries are used if they also matter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.