elastic / elastic/logstash

Prevent duplication of gem installation with bundler `--prefer-local` option

Open
#18,485 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
1d 4h
Merged PRs (30d)
88

Description

As a follow up to https://github.com/elastic/logstash/issues/17873 the bunlder flag `--prefer-local` should be used to prevent duplicating gem installation with bundler for gems included with jruby. Gems that explicitly must be duplicated (IE if the version shipped with jruby is unsuitable) will still be cleaned with the deduplication logic. Note that this was not included inititally due to jruby 9.4.13.0 not having a sutiable version of rubygems/bundler. See https://github.com/elastic/logstash/pull/18451 for investigation on carrying the patch that is required. Taking up this change will be blocked on a jruby release with a suitable rubygems version. Make sure that the pluginmanager and bundler patch in LS works with the forthcoming release.

Contributor guide

Open the contributing guide

Research direction

Start with the pluginmanager and Bundler patch in Logstash, then review the investigation in pull request 18451 and the deduplication logic. Verify the forthcoming JRuby release has suitable Rubygems and Bundler versions, and confirm that --prefer-local prevents duplicate installation while explicitly incompatible gems are still cleaned up.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
build-system, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.