elastic / elastic/logstash

chore: audit junit tests with logging assertions

Open
#16,896 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
14.9k
Forks
3.5k
Avg merge
19h 14m
Merged PRs (30d)
63

Description

We have a variety of ways of asserting that logs are emitted, and have run into situations where the order of tests being run affects whether assertions succeed. We should audit these methods and standardize the way we verify that logs are emitted so that we stop running into these frustrations.

Related:
- https://github.com/elastic/logstash/pull/16719#discussion_r1856937636
- https://github.com/elastic/logstash/pull/16643#discussion_r1911727880
- anything that uses [`logstash-core/src/test/resources/log4j2*`](https://github.com/elastic/logstash/tree/main/logstash-core/src/test/resources) to modify the logging configuration during test execution

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.