elastic / elastic/kibana-github-actions

shields.io badges will fail on private repo

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2
Forks
16
Avg merge
2d 3h
Merged PRs (30d)
1

Description

This is what we get on private repositories on a successful backport, for the link to the backport.

Screenshot 2021-08-19 at 14 46 05

The code here https://github.com/elastic/kibana-github-actions/blob/main/backport/createStatusComment.ts#L24
is using `https://img.shields.io/github/pulls/detail/state/${repoOwner}/${repoName}/${backportPullNumber}`

which won't work on any private repo.

It looks like it's quite complicated to do properly (see https://github.com/badges/shields/issues/593)
my proposal is to fallback to a generic image. We could do this in full JS on the client side when the image 404s..

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.