elastic / elastic/go-libaudit

Reassembler perfomance improvement

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
162
Forks
74
PR merge metrics
No merged PRs in 30d

Description

Hello!

I found, that on every new event reassembler sort sequenceNumSlice, which leads perfomance issues on high audit rate limits. I think it can be improved if make sort only if difference between new sequence and last:

```golang
l.seqs = append(l.seqs, seq)

if len(l.seqs) > 1 {
lastSeq := l.seqs[len(l.seqs)-2]

diff := abs(int64(seq) - int64(lastSeq))
if diff > maxSortRange || diff < 0 {
l.seqs.Sort()
}
}
```

What do you think about such improvement?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.