elastic / elastic/fleet-server

Remove (extra) args from poll `Checkin` call

Open
#5,517 0 comments 0 reactions 0 assignees View on GitHub
Team:Elastic-Agent-Control-Plane
Dominant language
Go
Stars
113
Forks
117
Avg merge
1d 16h
Merged PRs (30d)
112

Description

Currently the call to checkin within the polling loop uses extra args that get stored within the bulk checkin's `extraT` struct. Having anything in this struct prevents the bulk checkin handler from re-using serializations for different agents; these args should be removed.

https://github.com/elastic/fleet-server/blob/898abd59e2fe81e0ffe5a4dd060bf89396d326a3/internal/pkg/api/handleCheckin.go#L386-L389

We should also test removing all optional args in this invocation as the purpose of the loop `Checkin` is to update the timestamps, not any of the other attributes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.