[Icons] Remove persisted deprecated aliases
- Dominant language
- TypeScript
- Stars
- 6.4k
- Forks
- 911
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 65
Description
This is a follow-up to https://github.com/elastic/eui/issues/9561. The purpose is to remove the leftover deprecated icon aliases:
- `alert` (new handle: `warning`)
- `compute` (new handle: `processor`)
- `editorComment` (new handle: `comment`)
- `list` (new handle: `listBullet`)
- `mapMarker` (new handle: `waypoint`)
- `pinFilled` (new handle: `pinFill`)
- `search` (new handle: `magnify`)
- `starEmpty` (new handle: `star`)
- `starFilled` (new handle: `starFill`)
- `temperature` (new handle: `thermometer`)
- `visArea` (new handle: `chartArea`)
- `visBarVertical` (new handle: `chartBarVertical`)
- `visGauge` (new handle: `chartGauge`)
- `visLine` (new handle: `chartLine`)
- `visPie` (new handle: `chartPie`)
- `visTable` (new handle: `table`)
They were left to avoid breaking persisted cases in Kibana. We can only remove them once a migration mechanism is in place:
@elastic/kibana-visualizations
- `src/platform/packages/shared/kbn-event-annotation-common/index.ts`
- `src/platform/packages/shared/kbn-lens-common/visualizations/metric/constants.ts`
- `src/platform/packages/shared/kbn-lens-common/visualizations/xy/constants.ts`
- `src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/charts/metric.ts`
- `src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/transforms/charts/xy/helpers.ts`
- `src/platform/packages/shared/kbn-visualization-ui-components/types.ts`
- `src/platform/packages/shared/kbn-visualization-ui-components/util.ts`
- `src/platform/plugins/shared/chart_expressions/expression_metric/common/constants.ts`
- `src/platform/plugins/shared/chart_expressions/expression_xy/common/constants.ts`
- `src/platform/plugins/shared/vis_types/timeseries/public/application/visualizations/constants/icons.ts`
- `x-pack/platform/plugins/private/graph/public/helpers/style_choices.ts`
- `x-pack/platform/plugins/shared/lens/public/shared_components/icon_set.tsx`
@elastic/actionable-obs-team
- `x-pack/solutions/observability/plugins/observability/public/components/annotations/icon_set.ts`
- `x-pack/solutions/observability/plugins/infra/public/alerting/metric_threshold/components/alert_details_app_section.tsx`
- `x-pack/solutions/observability/plugins/observability/public/components/custom_threshold/components/alert_details_app_section/alert_details_app_section.tsx`
- `x-pack/solutions/observability/plugins/slo/public/components/slo/error_rate_chart/use_lens_definition.ts`
**See for more context:** https://github.com/elastic/kibana/pull/279452#discussion_r3623025100
Contributor guide
Research direction
Start by reading follow-up issue 9561 and the linked Kibana discussion, then review the listed Kibana files to understand where the deprecated aliases are persisted. Confirm that a migration mechanism is in place before removing the aliases from EUI; done means the listed deprecated handles can be removed without breaking persisted Kibana cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- design, frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100