elastic / elastic/elasticsearch-sql-odbc
Installation Prerequisite Check on Windows 7
- Dominant language
- C
- Stars
- 18
- Forks
- 33
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 4
Description
### Failed Installations
### Environment
Windows 7 32 bit
### Expected Behaviour
Failed with unsupported OS
### Actual Behaviour
Installer failed with
```
This installer requires the Visual 2017 C++ Redistributable (x86)
```
from https://github.com/elastic/elasticsearch-sql-odbc/blob/6.8/installer/src/Installer/Program.cs#L154
It should have failed in https://github.com/elastic/elasticsearch-sql-odbc/blob/6.8/installer/src/Installer/Program.cs#L149
but somehow windows 7 still passed?
### Steps to reproduce the behaviour
Install ODBC driver 6.8.0 on a Windows 7
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in installer/src/Installer/Program.cs at lines 149 and 154, then reproduce the 6.8.0 ODBC driver installation on 32-bit Windows 7. Trace why the Windows 7 check passes before the Visual 2017 C++ Redistributable prerequisite check. Done means unsupported Windows 7 installations fail at the OS check with the intended message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system, operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100