elastic / elastic/elasticsearch-java

Weird methods in ElasticsearchClient

Open
#145 1 comment 1 reaction 0 assignees View on GitHub
Category: Enhancement
Dominant language
Java
Stars
524
Forks
300
Avg merge
1d 11h
Merged PRs (30d)
16

Description

There are methods in `ElasticsearchClient` that look like not very useful.

They do not take any parameter, therefore using the builder internally without setting any value. When called, they raise an `IllegalStateException`.

Examples
- [public BulkResponse bulk()](https://github.com/elastic/elasticsearch-java/blob/e6d2abe7b98135b5885c218ef0c7e55cb8f93ac1/java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java#L339-L342)
- [public MtermvectorsResponse mtermvectors()](https://github.com/elastic/elasticsearch-java/blob/e6d2abe7b98135b5885c218ef0c7e55cb8f93ac1/java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java#L1138-L1141)
- [public FieldCapsResponse fieldCaps()](https://github.com/elastic/elasticsearch-java/blob/e6d2abe7b98135b5885c218ef0c7e55cb8f93ac1/java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java#L800-L803)
- [public ReindexResponse reindex()](https://github.com/elastic/elasticsearch-java/blob/e6d2abe7b98135b5885c218ef0c7e55cb8f93ac1/java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java#L1306-L1309)
- [public RenderSearchTemplateResponse renderSearchTemplate()](https://github.com/elastic/elasticsearch-java/blob/e6d2abe7b98135b5885c218ef0c7e55cb8f93ac1/java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java#L1389-L1392)

Looking at the API documentation, there is a least some mandatory parameter.

Is this maybe the result of generating the client based on the API specification and they should better be removed?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.