elastic / elastic/elastic-transport-python

Setting "sniff_before_requests=True" leads to repeatedly retrieving fail sniff tasks during requests

Open
#256 0 comments 0 reactions 0 assignees View on GitHub
tracking
Dominant language
Python
Stars
24
Forks
19
PR merge metrics
No merged PRs in 30d

Description

sorry my english is poor

in elastic_transport/_async_transport.py

when sniff_before_requests=True,sniff function call is not wrapped in a try-catch block, which causes exceptions from task.result to propagate outward.
Image

Image

If last sniff task return a timeout exception,this sniff(False) function will repeatedly retrieving failed sniff task Exception and never recover

and I observed other place using the func will wrap it with try catch

Image

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.