elastic / elastic/elastic-agent

An incomplete artifact fails without checking fallback sources when skip-verify is used

Open
#16,192 4 comments 2 reactions 1 assignee Claimed by @lorienhu View on GitHub
bug Team:Elastic-Agent-Control-Plane
Dominant language
Go
Stars
275
Forks
264
Avg merge
1d 23h
Merged PRs (30d)
312

Description

With skip-verify, the artifact downloader has no way of validating whether a fetched artifact is a functional Elastic Agent archive and stops after fetching the first source. If the artifact is malformed, it doesn't fail until either the package metadata or unpacking step, after we've already left the fallback source loop. Potentially valid sources are never tried afterward and the upgrade fails entirely.

The fallback failure in #16191 is caused by this. It's also relevant to the upcoming multiple download URI feature in #16097.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.