elastic / elastic/elastic-agent-libs

logp: handle environment configuration in DefaultConfig

Open
#238 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
6
Forks
57
Avg merge
6d 7h
Merged PRs (30d)
3

Description

With the change from https://github.com/elastic/elastic-agent-libs/pull/236 we now handle the environment in multiple places when initializing a logger.

We can try and keep this logic in `logp.DefaultConfig` in order to clean up [createLogOutput](https://github.com/elastic/elastic-agent-libs/blob/196dace11604a4403f4466812a150ff993c0261c/logp/core.go#L264-L271).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with logp/core.go, especially createLogOutput at lines 264-271, and inspect logp.DefaultConfig alongside the environment-handling change in pull request 236. Determine which initialization logic is duplicated and confirm that environment configuration is centralized in DefaultConfig while createLogOutput is simplified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.