elastic / elastic/ecs-typescript

WDYT: Since we are otherwise just blindly inserting this string into the `ecs.version` field and it comes from an external source, is it worth performing some sort of validation here so we can fail with a useful error message if something unexpected comes back? Could be as simple as a [`semver.valid`](https://github.com/npm/node-semver) check.

Open
#27 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
4
Forks
4
PR merge metrics
No merged PRs in 30d

Description

WDYT: Since we are otherwise just blindly inserting this string into the `ecs.version` field and it comes from an external source, is it worth performing some sort of validation here so we can fail with a useful error message if something unexpected comes back? Could be as simple as a [`semver.valid`](https://github.com/npm/node-semver) check.

_Originally posted by @lukeelmers in https://github.com/elastic/ecs-typescript/pull/20#discussion_r1065061947_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.