elastic / elastic/ecs-logging-nodejs

update loggers to use the bool retval of formatError, formatHttpRequest, and formatHttpResponse

Open
#70 0 comments 0 reactions 0 assignees View on GitHub
agent-nodejs
Dominant language
JavaScript
Stars
69
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Now that formatError, formatHttpRequest, and formatHttpResponse return a bool for whether they processed the field, the loggers should use that to pass through *un*processed fields on the log record. Currently logging a `req` field that isn't an HTTP request will (a) blow up in v1.0.0, (b) silently drop the "req" field in v1.1.0. I think a future version should log that `req` field unchanged.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.