elastic / elastic/ecs-logging-nodejs
consider using `URL` for parsing in helpers.formatHttpRequest
Open
agent-nodejs
- Dominant language
- JavaScript
- Stars
- 69
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
Currently `formatHttpRequest` is manually doing URL parsing. I think using the standard `url.URL` for parsing would fix potential issues with weird URLs.
Also, in the case of a hapi request object, there is an already parsed `request.url` available. Express request objects might have the same thing. Not sure about other frameworks (e.g. fastify).
Contributor guide
Assessment
This issue has not been assessed yet.