elastic / elastic/detection-rules

Refactor NON_DATASET_PACKAGE approach to support packages

Open
#3,447 1 comment 0 reactions 0 assignees View on GitHub
backlog enhancement python Team: TRADE
Dominant language
Python
Stars
2.7k
Forks
696
Avg merge
4d 17h
Merged PRs (30d)
87

Description

## Summary

In https://github.com/elastic/detection-rules/pull/3430 we spent time sanity checking additions to NON_DATASET_PACKAGE. We currently have to double [check several things](https://github.com/elastic/detection-rules/pull/3430#issuecomment-1946503428), indicating potential opportunities to refactor.

We may want to rely on the index pattern to parse this information. We should also create a checklist if needed for future PRs.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing PR 3430 and its linked comment to understand the checks currently required for NON_DATASET_PACKAGE additions. Trace where this approach is validated, then determine whether index patterns can replace those checks and document the resulting checklist; done means package handling is simpler and future additions have clear guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.