Feature request: allow filtering nodes by attribute when shrinking
Open
Nobody has claimed this yet.
feature_request
- Dominant language
- Python
- Stars
- 3.1k
- Forks
- 627
- PR merge metrics
- No merged PRs in 30d
Description
The title pretty much says it all. It would be nice to be able to do something like:
action: shrink
node_filters:
exclude_attribute:
attribute: box_type
value: hot
Could also be useful to have an include_attribute as well.
May also apply to other actions also. Perhaps it's a good idea to decouple the node filters from the shrink action?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the shrink action and its existing node-filter handling, then trace how the shown action configuration is parsed. Compare the requested exclude_attribute and include_attribute behavior and determine whether filters should also apply to other actions; done means the scope and configuration behavior are defined and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- elasticsearch, python
- Domain
- cli, search
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100