elastic / elastic/beats

Filestream `LineReader.collectOnEOF` does not work

Open
#49,022 6 comments 0 reactions 1 assignee Claimed by @belimawr View on GitHub
needs_team
Dominant language
Go
Stars
12.7k
Forks
5k
Avg merge
2d 2h
Merged PRs (30d)
364

Description

Setting `collectOnEOF: true` on [`LineReader`](https://github.com/elastic/beats/blob/5c21dfffdcd5f073df09f27d8c358ffedb4d7ccb/libbeat/reader/readfile/line.go#L41) does not work. The [`advance`](https://github.com/elastic/beats/blob/5c21dfffdcd5f073df09f27d8c358ffedb4d7ccb/libbeat/reader/readfile/line.go#L173) method still blocks.

Setting `LineReader.collectOnEOF: true` should make the LineReader return a line when EOF is reached, even if there no EOL character.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.