elastic / elastic/app-search-reference-ui-react

[Feature Request] Support SearchKey as an Environment Variable

Open
#82 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
64
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Having the `searchKey` in the clear in `engine.json` is not the best approaches from a security point of view.

It would be great if the `searchKey` can be read at runtime from an environment variable.

As an example the `AppSearchAPIConnector` connector would be something like the following:

```
const connector = new AppSearchAPIConnector({
searchKey: process.env.REACT_APP_APPSEARCH_SEARCHKEY,
engineName,
hostIdentifier,
endpointBase
});
```

Would like to get your opinion on this before performing any work. Ready to submit a PR for this feature 😄

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.