elastic / elastic/apm

Rename the span_frames_min_duration property

Open
#94 10 comments 0 reactions 1 assignee Claimed by @basepi View on GitHub
apm-agents meta
Dominant language
Gherkin
Stars
427
Forks
125
PR merge metrics
No merged PRs in 30d

Description

The `span_frames_min_duration` seems to be used to decide whether or not to collect stack traces for a span.
The problem is that this information only becomes clear after reading the full documentation, as the name of the property does not make this easy to guess.
It would be better if the name of the property was clear enough for the user to know what it is used for.
Maybe `stack_trace_span_min_duration`, for example.

## Spec issue
- [x] https://github.com/elastic/apm/issues/528 Milestone

## Agent issues
- [x] https://github.com/elastic/apm-agent-java/issues/2206 Milestone
- [x] https://github.com/elastic/apm-agent-dotnet/issues/1529 Milestone
- [x] https://github.com/elastic/apm-agent-go/issues/1142 Milestone
- [x] https://github.com/elastic/apm-agent-php/issues/568 Milestone
- [ ] https://github.com/elastic/apm-agent-ruby/issues/1174 Milestone
- [x] https://github.com/elastic/apm-agent-nodejs/issues/2381 Milestone
- [x] https://github.com/elastic/apm-agent-python/issues/1369 Milestone

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.