elastic / elastic/apm

Signify that a stack trace was truncated

Open
#89 11 comments 2 reactions 0 assignees View on GitHub
apm-agents discussion
Dominant language
Gherkin
Stars
427
Forks
125
PR merge metrics
No merged PRs in 30d

Description

## Description of the issue

A few agents (Java, Ruby at least) have the option to truncate stack traces to _x_ lines. Currently this is done by simply chopping off the bottom.

However there's no indication in the UI to the user that this has happened, perhaps leading to confusion.

Suggestions for implementation:

- `stacktrace: { truncated: true }`. A simple boolean is likely the simplest solution.
- `stacktrace: { truncated: 9 }`. However a count is probably just as easy to save while giving a bit more information.
- `stacktrace: { truncated: [[0, 3], [6, 10]] }`. If we want to get even fancier in the future, for example doing middle truncation or truncation depending on lines being library or application code, we need to store the exact indexes so the UI can show _...truncated..._ in the right places.

## UPDATE

**We go with the simplest implementation, `stacktrace: { truncated: true }`.**

I suggest we make it optional on the server side for compatibility with older agents but default to `false` in agents when implemented?

## What we are voting on

Whether this is a feasible (and _good enough_) solution. Added a row for APM Server as this is going into the api too.

## Vote

| Agent | Yes | No | Indifferent | N/A | Link to agent issue
| --------|:----:|:---:|:-----------:|:----:|:-------------------:|
| APM Server |

  • [ ]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| .NET |
  • [x]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| Go |
  • [ ]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| Java |
  • [x]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| Node.js |
  • [ ]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| Python |
  • [x]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| Ruby |
  • [x]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|
| RUM |
  • [ ]
|
  • [ ]
|
  • [ ]
|
  • [ ]
|

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.