elastic / elastic/apm

Report FQDN for `detected_hostname`

Open
#793 0 comments 0 reactions 0 assignees View on GitHub
8.9-candidate apm-agents meta
Dominant language
Gherkin
Stars
427
Forks
125
PR merge metrics
No merged PRs in 30d

Description

# Description
ECS changed the definition of host.name and encourages to use the fully qualified domain name for the host name.

All Elastic ECS producers should populate the host.name field with the lowercased FQDN from here forward.

This change is behind a feature flag on the Elastic agent (to avoid breaking changes for users).

~APM agents do not know about the above-mentioned setting / feature flag. Thus, this decision needs to happen on the APM server.
However, **APM agents would need to collect the host.domain information in addition to enable the APM server to construct the FQDN.**~

**IMPORTANT UPDATE**: We keep it simple for APM agents. This change only requires the APM agents to always report the FQDN (instead of the simple) for the `detected_hostname` field.

## Spec Issue
- [ ] https://github.com/elastic/apm/issues/794 Milestone

## Agent Issues
- [ ] https://github.com/elastic/apm-agent-java/issues/3131 Milestone
- [ ] https://github.com/elastic/apm-agent-dotnet/issues/2065 Milestone
- [x] https://github.com/elastic/apm-agent-nodejs/issues/3310 Milestone
- [ ] https://github.com/elastic/apm-agent-python/issues/1824 Milestone
- [ ] https://github.com/elastic/apm-agent-go/issues/1425 Milestone
- [ ] https://github.com/elastic/apm-agent-php/issues/943 Milestone

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.