elastic / elastic/apm

Add existing options to central configuration

Open
#711 0 comments 0 reactions 0 assignees View on GitHub
8.7-candidate apm-agents meta
Dominant language
Gherkin
Stars
427
Forks
125
PR merge metrics
No merged PRs in 30d

Description

# Description

In https://github.com/elastic/kibana/pull/143668, I've added a bunch of config options to central configuration. So far, I've only added the `java` agent in the `includeAgents` section, meaning that these options only appear in central config when selecting a service that's traced with our Java agent. Both because I was too lazy to research which of these are supported in which agent and because it's a good opportunity to try out parts of the new process for adding options to central config (https://github.com/elastic/apm/pull/707).

This is the list of newly added configuration options:
```
capture_body_content_types
dedot_custom_metrics
exit_span_min_duration
ignore_message_queues
span_compression_enabled
span_compression_exact_match_max_duration
span_compression_same_kind_max_duration
trace_continuation_strategy
transaction_ignore_user_agents
transaction_name_groups
use_path_as_transaction_name
```

Please check which of these options are supported by your agent, ensure they can be loaded via central config, and add the agent name to the `includeAgents` section. You can just edit [`general_settings.ts`](https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/common/agent_configuration/setting_definitions/general_settings.ts) from the GitHub UI to create the PR. No need to set up a local dev environment or adjust tests when adding an agent to the `includeAgents` section of an existing configuration option.

After doing that, please link the Kibana PR from the agent implementation issue.

If all that needs to be done for an agent is to add the agent name to `includeAgents`, I was hoping that this could be done within the 8.6 timeframe as that's when the new set of options will be released. If more agent changes are needed, it might make more sense to postpone the changes.

## Agent Issues
- [ ] https://github.com/elastic/apm-agent-dotnet/issues/1886 Milestone
- [ ] https://github.com/elastic/apm-agent-nodejs/issues/3003 Milestone
- [ ] https://github.com/elastic/apm-agent-python/issues/1681 Milestone
- [ ] https://github.com/elastic/apm-agent-go/issues/1341 Milestone
- [ ] https://github.com/elastic/apm-agent-php/issues/811 Milestone
- [ ] https://github.com/elastic/apm-agent-ruby/issues/1318 Milestone

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.