elastic / elastic/apm

Remove context.db from S3 spans: S3 isn't a database

Open
#696 0 comments 0 reactions 0 assignees View on GitHub
apm-agents meta
Dominant language
Gherkin
Stars
427
Forks
125
PR merge metrics
No merged PRs in 30d

Description

# Description

`context.db.*` was added to the spec for AWS S3 spans *by accident*. As of spec change https://github.com/elastic/apm/pull/683 any S3 spans created by APM agent instrumentation should *not* set `span.context.db.*`.

(My read of the Go and Python APM agent implementations was that they already do not set `context.db.*` for S3 spans, so I didn't create implementation PRs for them.)

## Agent Issues
- [x] https://github.com/elastic/apm-agent-java/issues/2820 Milestone
- [ ] https://github.com/elastic/apm-agent-ruby/issues/1313 Milestone

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.