elastic / elastic/apm-server

apmbench: simplify the warmup logic by providing a `-warmup-time` flag

Open
#8,621 0 comments 0 reactions 0 assignees View on GitHub
benchmarking enhancement
Dominant language
Go
Stars
1.3k
Forks
543
Avg merge
1d 18h
Merged PRs (30d)
109

Description

## Description

Currently, `apmbench` uses an event-driven warmup which relies on a dynamically calculated timeout, all of which overly complicates the warm up logic. Instead, it would be better to switch to a time-based warmup approach and cause stop all the goroutines after the warmup has elapsed.

Introducing a new `-warmup-time` flag and removing `-warmup-events` will provide a more consistent and predictable behavior.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.