elastic / elastic/apm-server

Update server reload to not reset aggregation/sampling

Open
#5,913 0 comments 0 reactions 0 assignees View on GitHub
enhancement fleet
Dominant language
Go
Stars
1.3k
Forks
543
Avg merge
1d 18h
Merged PRs (30d)
109

Description

Reloading the apm-server config under fleet currently utilizes `SO_REUSEPORT` to start a second server with the updated config that listens on the same port, and then shuts down the old server.

As mentioned in [this comment](
https://github.com/elastic/apm-server/pull/5897#pullrequestreview-724974474), this approach has the undesirable effect of resetting aggregation and sampling on each config reload.

Figure out a way to persist sampling and aggregation through reloads.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.