elastic / elastic/apm-server

Replace global paths

Open
#20,793 2 comments 0 reactions 1 assignee Claimed by @orestisfl View on GitHub
Team:Elastic-Agent-Data-Plane
Dominant language
Go
Stars
1.3k
Forks
543
Avg merge
1d 8h
Merged PRs (30d)
117

Description

We are deprecating and removing global paths from the elastic-agent-libs library

Even though apm-server is not affected, we would like to completely prevent this situation from re-occuring by completely removing the global accessors. Additionally, this is defensive against potential bugs occurring in the future. For example in https://github.com/elastic/apm-server/blob/1192ac741db23f774fa9cf07451da4906055568d/internal/beatcmd/beat.go#L140-L165 the paths object is not initialized in the Beat{} struct. Future changes in the beats repo could lead to accessing a nil pointer.

~~Blocked by https://github.com/elastic/beats/issues/49803~~

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.