elastic / elastic/apm-agent-ruby

Amazon SNS service -> service name includes topic

Open
#1,511 0 comments 0 reactions 0 assignees View on GitHub
agent-ruby bug
Dominant language
Ruby
Stars
173
Forks
151
Avg merge
4d 8h
Merged PRs (30d)
2

Description

Hi,

While looking at our dependencies, I found that Amazon SNS service's name is equal to `subtype/topic_id`. You can imagine having multiple topic what kind of graph is rendered. I think having 1 service SNS would be enough for most cases.

The resource is set [here](https://github.com/elastic/apm-agent-ruby/blob/5f6fc2bad4857f43bbb0b177a97c6149cbd78650/lib/elastic_apm/spies/sns.rb#L66-L71) and I would gladly open a PR to change it.

Thanks.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.