elastic / elastic/apm-agent-php

[META 448] Auto-infer destination.service.resource and adapt public API

Open
#426 0 comments 0 reactions 0 assignees View on GitHub
agent-php cross APM agents priority: low triaged
Dominant language
PHP
Stars
268
Forks
86
PR merge metrics
No merged PRs in 30d

Description

As described in https://github.com/elastic/apm/issues/448, the agent needs to apply the following changes to comply with the current SPEC for destination fields:

- [x] Infer destination.service.resource based on other fields
- [ ] Add a public API to set destination.service.resource
- [x] As destination.service.name and destination.service.type are not used anywhere in the product, I propose to deprecate and remove them also in the public API (if already added there)
- [ ] Add a public API to start an exit span. This auto-infers the destination.service.resource based on the subtype if not set otherwise. Avoids creating nested exit spans and makes the service map work with those custom spans by default, without having to set any destination fields.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.