elastic / elastic/apm-agent-php
Responsibility for integration with framework should be part of "pluggins"
- Dominant language
- PHP
- Stars
- 268
- Forks
- 86
- PR merge metrics
- No merged PRs in 30d
Description
**Is your feature request related to a problem? Please describe.**
Integration with laravel should be part of the composer package but not this project
For example this commit: https://github.com/elastic/apm-agent-php/commit/32cf6e9a62b7df8b9e34e4671f324a28aca8f7fa#diff-b47c6775fb905ec115037a7131910fd0fa50c554269bcb6c418a6017fd7987f3
Invent knowledge of laravel artisan.
PROBLEM:
In order to contribute we need deep knowledge of this extension to be able to create integration with any third-party tools.
This project should be responsible only for offering a set of APIs which going to be used inside of the "integration" package.
This will reduce the responsibility to keep up with third-party tool releases and make this package "totally" independent.
For example, if LARAVEL decided to rename **artisan** to something else - we would need to update this repository but this particular change is only needed by people who use **laravel** not by others.
**Describe the solution you'd like**
Deprecate any integration with any framework and offer a separate package that is going to be responsible for integration with a framework for example naming laravel cli command or HTTP
The same goes for Symfony and any framework.
There are already packages which doing so like https://github.com/MySchoolManagement/elastic-apm-symfony-bundle
BENEFITS:
Maintainer of this repository can decrease load and do something that really useful for everyone.
**Additional context**
Contributor guide
Assessment
This issue has not been assessed yet.