elastic / elastic/apm-agent-nodejs

`ignoreUrls` and `transactionIgnoreUrls` match against `req.url`, it should match only the pathname

Open
#3,667 0 comments 0 reactions 0 assignees View on GitHub
agent-nodejs
Dominant language
JavaScript
Stars
594
Forks
244
Avg merge
1d 8h
Merged PRs (30d)
16

Description

With an APM agent configured with:

```
transactionIgnoreUrls: ['/robots.txt']
```

will ignore an incoming `GET /robots.txt` request, but *not* an incoming `GET /robots.txt?query`.

The matching code (`shouldIgnoreRequest` in "http-shared.js") is matching with [`req.url`](https://nodejs.org/api/all.html#all_http_messageurl). We will need to (carefully) parse the `req.url` to get just the pathname to match against.
The [spec is clear](https://github.com/elastic/apm/blob/main/specs/agents/tracing-instrumentation-http.md#transaction_ignore_urls-configuration) with a specific `http://whatever.com/home/index?value1=123` example.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.