elastic / elastic/apm-agent-nodejs

the `npm publish` step of the release process will use a "latest" dist-tag for a pre-release and should not

Open
#3,615 0 comments 0 reactions 1 assignee Claimed by @trentm View on GitHub
8.11-candidate agent-nodejs
Dominant language
JavaScript
Stars
594
Forks
244
Avg merge
1d 8h
Merged PRs (30d)
16

Description

I did a 4.0.0-rc.1 release recently. The resulting npm published package was dist-tagged with "latest":

```
% npm info elastic-apm-node dist-tags
{ latest: '4.0.0-rc.1', '2x': '2.17.3' }
```

The intent is that it does *not* mark a pre-release (a version with a hyphen in it) as "latest". I had played with https://www.npmjs.com/package/@trentm/npmplay and got the wrong impression that a bare `npm publish` would do the "right" thing (at least what I wanted). However, that isn't the case.

Proposal: have a "dev-utils/npm-publish.sh" that does the equivalent handling of dist-tagging that is done in "push-docker.sh" and "github-release.sh". As a bonus, we could possibly have it handle the "latest-" explicitly dist-tagging for non-latest-major maintenance branches, i.e. for the current "3.x" branch.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.