elastic / elastic/apm-agent-nodejs

next@13.3.0 support

Open
#3,263 7 comments 0 reactions 0 assignees View on GitHub
agent-nodejs
Dominant language
JavaScript
Stars
594
Forks
244
Avg merge
1d 8h
Merged PRs (30d)
16

Description

Next.js 13.3.0 broke our (experimental) instrumentation -- see the test failures on this dependabot PR: https://github.com/elastic/apm-agent-nodejs/pull/3257

(Similarly, next@13.2.0 broke our instrumentation not so long ago: https://github.com/elastic/apm-agent-nodejs/pull/3178)

This issue is to add support for next@13.3.0. In the interim, we will have a quick PR to change the version guard on Next.js instrumentation support to be on the *minor* version (`... <13.3.0`) rather than on the *major* version (`... <14.0.0`) as is more typical of other instrumentations. (It makes some sense that our instrumentation is more brittle here, because we are digging into Next.js internal routing code that isn't very amenable to being instrumentation -- at least at the level that I tried for.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.